From 82a93a1d307064f35c363f79b04b0a0149ac53d9 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Mon, 3 Jul 2017 20:20:53 +1000 Subject: spapr: Remove 'awaiting_allocation' DRC flag The awaiting_allocation flag in the DRC was introduced by aab9913 "spapr_drc: Prevent detach racing against attach for CPU DR", allegedly to prevent a guest crash on racing attach and detach. Except.. information from the BZ actually suggests a qemu crash, not a guest crash. And there shouldn't be a problem here anyway: if the guest has already moved the DRC away from UNUSABLE state, the detach would already be deferred, and if it hadn't it should be safe to detach it (the guest should fail gracefully when it attempts to change the allocation state). I think this was probably just a bandaid for some other problem in the state management. So, remove awaiting_allocation and associated code. Signed-off-by: David Gibson Reviewed-by: Laurent Vivier Reviewed-by: Greg Kurz Tested-by: Greg Kurz Tested-by: Daniel Barboza --- include/hw/ppc/spapr_drc.h | 1 - 1 file changed, 1 deletion(-) (limited to 'include/hw/ppc') diff --git a/include/hw/ppc/spapr_drc.h b/include/hw/ppc/spapr_drc.h index 715016b052..18a196e831 100644 --- a/include/hw/ppc/spapr_drc.h +++ b/include/hw/ppc/spapr_drc.h @@ -200,7 +200,6 @@ typedef struct sPAPRDRConnector { sPAPRConfigureConnectorState *ccs; bool awaiting_release; - bool awaiting_allocation; /* device pointer, via link property */ DeviceState *dev; -- cgit v1.2.3