From e35f29ded3602a2ff6776290787c596ce6afc802 Mon Sep 17 00:00:00 2001 From: Saravanakumar Date: Wed, 21 May 2014 16:11:40 +0530 Subject: jazz_led: Add missing break in switch case Signed-off-by: Saravanakumar Reviewed-by: Paolo Bonizni Signed-off-by: Michael Tokarev --- hw/display/jazz_led.c | 1 + 1 file changed, 1 insertion(+) (limited to 'hw') diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index e9bb005413..12b1707cb2 100644 --- a/hw/display/jazz_led.c +++ b/hw/display/jazz_led.c @@ -173,6 +173,7 @@ static void jazz_led_update_display(void *opaque) case 16: color_segment = rgb_to_pixel16(0xaa, 0xaa, 0xaa); color_led = rgb_to_pixel16(0x00, 0xff, 0x00); + break; case 24: color_segment = rgb_to_pixel24(0xaa, 0xaa, 0xaa); color_led = rgb_to_pixel24(0x00, 0xff, 0x00); -- cgit v1.2.3 From b645000e1ac430601eddb0b435936837aea94bb4 Mon Sep 17 00:00:00 2001 From: Saravanakumar Date: Thu, 22 May 2014 17:03:50 +0530 Subject: pci: move dereferencing of root only after verifying valid root pointer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Saravanakumar Reviewed-by: Andreas Färber Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- hw/pci/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'hw') diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 22fe5eec36..8d6a8d4e74 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -605,13 +605,13 @@ PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, const char *devaddr) int dom, bus; unsigned slot; - assert(!root->parent_dev); - if (!root) { fprintf(stderr, "No primary PCI bus\n"); return NULL; } + assert(!root->parent_dev); + if (!devaddr) { *devfnp = -1; return pci_find_bus_nr(root, 0); -- cgit v1.2.3 From 116d55460186d8568428072a5bbc355fb0129fce Mon Sep 17 00:00:00 2001 From: Peter Crosthwaite Date: Wed, 7 May 2014 02:17:31 -0700 Subject: net: cadence_gem: Fix top comment To indicate Cadence GEM not Xilinx. Signed-off-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/net/cadence_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw') diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 47e70381fe..a26861e2ae 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -1,5 +1,5 @@ /* - * QEMU Xilinx GEM emulation + * QEMU Cadence GEM emulation * * Copyright (c) 2011 Xilinx, Inc. * -- cgit v1.2.3