From 8a0b4de048e20215415b24c7b42514c27b9d6ef3 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Thu, 30 Jun 2016 16:57:37 +0200 Subject: pcspk: fix KVM The link property that was added to the pcspk device has the wrong type: it is only correct for TCG and for KVM's userspace or split irqchip options. The default KVM option (fully in-kernel irqchip) breaks because it uses a PIT whose type is a sibling of TYPE_I8254. Fixes: 873b4d3f0571a1e415cf089a67a230ea8a12d059 Tested-by: Peter Lieven Signed-off-by: Paolo Bonzini Message-id: 1467298657-6588-1-git-send-email-pbonzini@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/audio/pcspk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw') diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index a7aa4e9c26..42a6f4885a 100644 --- a/hw/audio/pcspk.c +++ b/hw/audio/pcspk.c @@ -171,7 +171,7 @@ static void pcspk_initfn(Object *obj) memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1); - object_property_add_link(obj, "pit", TYPE_I8254, + object_property_add_link(obj, "pit", TYPE_PIT_COMMON, (Object **)&s->pit, qdev_prop_allow_set_link_before_realize, 0, &error_abort); -- cgit v1.2.3