From 44b1ff319c4781c7ab13f7e119b3114a1e6a52e2 Mon Sep 17 00:00:00 2001 From: "Dr. David Alan Gilbert" Date: Mon, 25 Sep 2017 12:29:12 +0100 Subject: migration: pre_save return int Modify the pre_save method on VMStateDescription to return an int rather than void so that it potentially can fail. Changed zillions of devices to make them return 0; the only case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already had an error_report/return case. Note: If you add an error exit in your pre_save you must emit an error_report to say why. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170925112917.21340-2-dgilbert@redhat.com> Reviewed-by: Peter Xu Reviewed-by: Cornelia Huck Reviewed-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- hw/scsi/vmw_pvscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'hw/scsi/vmw_pvscsi.c') diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index 6d3f0bf11d..d8079158ac 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1167,7 +1167,7 @@ pvscsi_reset(DeviceState *dev) pvscsi_reset_adapter(s); } -static void +static int pvscsi_pre_save(void *opaque) { PVSCSIState *s = (PVSCSIState *) opaque; @@ -1176,6 +1176,8 @@ pvscsi_pre_save(void *opaque) assert(QTAILQ_EMPTY(&s->pending_queue)); assert(QTAILQ_EMPTY(&s->completion_queue)); + + return 0; } static int -- cgit v1.2.3