From a27bd6c779badb8d76e4430d810ef710a1b98f4e Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:51 +0200 Subject: Include hw/qdev-properties.h less MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In my "build everything" tree, changing hw/qdev-properties.h triggers a recompile of some 2700 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Many places including hw/qdev-properties.h (directly or via hw/qdev.h) actually need only hw/qdev-core.h. Include hw/qdev-core.h there instead. hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h and hw/qdev-properties.h, which in turn includes hw/qdev-core.h. Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h. While there, delete a few superfluous inclusions of hw/qdev-core.h. Touching hw/qdev-properties.h now recompiles some 1200 objects. Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Signed-off-by: Markus Armbruster Reviewed-by: Eduardo Habkost Message-Id: <20190812052359.30071-22-armbru@redhat.com> --- hw/pci-host/designware.c | 1 + hw/pci-host/gpex.c | 1 + hw/pci-host/grackle.c | 1 + hw/pci-host/piix.c | 1 + hw/pci-host/ppce500.c | 1 + hw/pci-host/prep.c | 1 + hw/pci-host/q35.c | 1 + hw/pci-host/sabre.c | 1 + hw/pci-host/uninorth.c | 1 + hw/pci-host/versatile.c | 1 + hw/pci-host/xilinx-pcie.c | 1 + 11 files changed, 11 insertions(+) (limited to 'hw/pci-host') diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index 083f5bb1a6..71e9b0d9b5 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -25,6 +25,7 @@ #include "hw/pci/pci_bridge.h" #include "hw/pci/pci_host.h" #include "hw/pci/pcie_port.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/irq.h" #include "hw/pci-host/designware.h" diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c index 93f28efb49..0ca604dc62 100644 --- a/hw/pci-host/gpex.c +++ b/hw/pci-host/gpex.c @@ -33,6 +33,7 @@ #include "qapi/error.h" #include "hw/irq.h" #include "hw/pci-host/gpex.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/module.h" diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 912f8bf13f..537273e578 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -26,6 +26,7 @@ #include "qemu/osdep.h" #include "hw/pci/pci_host.h" #include "hw/ppc/mac.h" +#include "hw/qdev-properties.h" #include "hw/pci/pci.h" #include "hw/intc/heathrow_pic.h" #include "hw/irq.h" diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index bc9726057a..2e97bc0bdb 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -27,6 +27,7 @@ #include "hw/irq.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" +#include "hw/qdev-properties.h" #include "hw/isa/isa.h" #include "hw/sysbus.h" #include "qapi/error.h" diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index 241e7e788d..8bed8e8941 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -17,6 +17,7 @@ #include "qemu/osdep.h" #include "hw/irq.h" #include "hw/ppc/e500-ccsr.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 588c7dc6c0..85d7ba9037 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -30,6 +30,7 @@ #include "hw/pci/pci.h" #include "hw/pci/pci_bus.h" #include "hw/pci/pci_host.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/i386/pc.h" #include "hw/irq.h" diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 1688a89b6a..158d270b9f 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -30,6 +30,7 @@ #include "qemu/osdep.h" #include "hw/pci-host/q35.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qapi/error.h" #include "qapi/visitor.h" diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 772ac1f725..a6520511b4 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -28,6 +28,7 @@ #include "hw/sysbus.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" +#include "hw/qdev-properties.h" #include "hw/pci/pci_bridge.h" #include "hw/pci/pci_bus.h" #include "hw/irq.h" diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index 76293ab22b..75bc506965 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host/uninorth.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "hw/irq.h" #include "hw/ppc/mac.h" +#include "hw/qdev-properties.h" #include "qemu/module.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index 1cd832a393..b731d0544f 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -14,6 +14,7 @@ #include "hw/pci/pci.h" #include "hw/pci/pci_bus.h" #include "hw/pci/pci_host.h" +#include "hw/qdev-properties.h" #include "qemu/log.h" #include "qemu/module.h" diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c index f42fabbbe7..17d5024349 100644 --- a/hw/pci-host/xilinx-pcie.c +++ b/hw/pci-host/xilinx-pcie.c @@ -22,6 +22,7 @@ #include "qemu/units.h" #include "qapi/error.h" #include "hw/pci/pci_bridge.h" +#include "hw/qdev-properties.h" #include "hw/irq.h" #include "hw/pci-host/xilinx-pcie.h" -- cgit v1.2.3