From cedf9a6f4549900f857954059284a96814e4c7a3 Mon Sep 17 00:00:00 2001 From: Blue Swirl Date: Wed, 12 Jan 2011 19:48:57 +0000 Subject: loader: fix a file descriptor leak Fix a file descriptor leak, reported by cppcheck: [/src/qemu/hw/loader.c:311]: (error) Resource leak: fd Signed-off-by: Blue Swirl --- hw/loader.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'hw/loader.c') diff --git a/hw/loader.c b/hw/loader.c index eb198f6723..35d792e647 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -307,8 +307,9 @@ int load_elf(const char *filename, uint64_t (*translate_fn)(void *, uint64_t), target_data_order = ELFDATA2LSB; } - if (target_data_order != e_ident[EI_DATA]) - return -1; + if (target_data_order != e_ident[EI_DATA]) { + goto fail; + } lseek(fd, 0, SEEK_SET); if (e_ident[EI_CLASS] == ELFCLASS64) { -- cgit v1.2.3