From 99b0f0584132d942547046bc064478db5bcbe7c5 Mon Sep 17 00:00:00 2001 From: Mark Cave-Ayland Date: Fri, 3 Sep 2021 12:32:22 +0100 Subject: escc: re-use escc_reset_chn() for soft reset This removes duplication of the internal device state initialisation between device reset and soft reset. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Message-Id: <20210903113223.19551-9-mark.cave-ayland@ilande.co.uk> Signed-off-by: Mark Cave-Ayland --- hw/char/escc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'hw/char') diff --git a/hw/char/escc.c b/hw/char/escc.c index 22c97414a1..9283ed70a6 100644 --- a/hw/char/escc.c +++ b/hw/char/escc.c @@ -288,7 +288,8 @@ static void escc_reset_chn(ESCCChannelState *s) static void escc_soft_reset_chn(ESCCChannelState *s) { - s->reg = 0; + escc_reset_chn(s); + s->wregs[W_CMD] = 0; s->wregs[W_INTR] &= INTR_PAR_SPEC | INTR_WTRQ_TXRX; s->wregs[W_RXCTRL] &= ~RXCTRL_RXEN; @@ -314,12 +315,6 @@ static void escc_soft_reset_chn(ESCCChannelState *s) s->rregs[R_SPEC] |= SPEC_BITS8; s->rregs[R_INTR] = 0; s->rregs[R_MISC] &= MISC_2CLKMISS; - - s->rx = s->tx = 0; - s->rxint = s->txint = 0; - s->rxint_under_svc = s->txint_under_svc = 0; - s->e0_mode = s->led_mode = s->caps_lock_mode = s->num_lock_mode = 0; - clear_queue(s); } static void escc_hard_reset_chn(ESCCChannelState *s) -- cgit v1.2.3