From ae8622ec1971cd4a63db4da25ecffa9ba21f811c Mon Sep 17 00:00:00 2001 From: Peter Maydell Date: Fri, 18 May 2018 19:17:17 +0100 Subject: sheepdog: Remove unnecessary NULL check in sd_prealloc() In commit 8b9ad56e9cbfd852a, we removed the code that could result in our getting to sd_prealloc()'s out_with_err_set label with a NULL blk pointer. That makes the NULL check in the error-handling path unnecessary, and Coverity gripes about it (CID 1390636). Delete the redundant check. Signed-off-by: Peter Maydell Signed-off-by: Kevin Wolf --- block/sheepdog.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'block') diff --git a/block/sheepdog.c b/block/sheepdog.c index 4237132419..2a5bc0a59a 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -1859,9 +1859,7 @@ out: error_setg_errno(errp, -ret, "Can't pre-allocate"); } out_with_err_set: - if (blk) { - blk_unref(blk); - } + blk_unref(blk); g_free(buf); return ret; -- cgit v1.2.3