From 5ad81b4946baf948c65cf7e1436d9b74803c1280 Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Fri, 15 Feb 2019 16:53:51 +0100 Subject: nbd: Restrict connection_co reentrance nbd_client_attach_aio_context() schedules connection_co in the new AioContext and this way reenters it in any arbitrary place that has yielded. We can restrict this a bit to the function call where the coroutine actually sits waiting when it's idle. This doesn't solve any bug yet, but it shows where in the code we need to support this random reentrance and where we don't have to care. Add FIXME comments for the existing bugs that the rest of this series will fix. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/nbd-client.h | 1 + 1 file changed, 1 insertion(+) (limited to 'block/nbd-client.h') diff --git a/block/nbd-client.h b/block/nbd-client.h index d990207a5c..09e03013d2 100644 --- a/block/nbd-client.h +++ b/block/nbd-client.h @@ -35,6 +35,7 @@ typedef struct NBDClientSession { NBDClientRequest requests[MAX_NBD_REQUESTS]; NBDReply reply; + BlockDriverState *bs; bool quit; } NBDClientSession; -- cgit v1.2.3