From b92a0011b1220aff549ae82c6104014d25e339ef Mon Sep 17 00:00:00 2001 From: Amador Pahim Date: Fri, 1 Sep 2017 13:28:21 +0200 Subject: qemu.py: include debug information on launch error When launching a VM, if an exception happens and the VM is not initiated, it might be useful to see the qemu command line and the qemu command output. This patch creates that message. Notice that self._iolog needs to be cleaned up in the beginning of the launch() to make sure we will not expose the qemu log from a previous launch if the current one fails. Signed-off-by: Amador Pahim Message-Id: <20170901112829.2571-6-apahim@redhat.com> Reviewed-by: Fam Zheng Signed-off-by: Eduardo Habkost --- scripts/qemu.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 9440261ac3..8c67595ec8 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -187,6 +187,7 @@ class QEMUMachine(object): def launch(self): '''Launch the VM and establish a QMP connection''' + self._iolog = None self._qemu_full_args = None devnull = open(os.path.devnull, 'rb') qemulog = open(self._qemu_log_path, 'wb') @@ -206,6 +207,12 @@ class QEMUMachine(object): self._popen.wait() self._load_io_log() self._post_shutdown() + + LOG.debug('Error launching VM') + if self._qemu_full_args: + LOG.debug('Command: %r', ' '.join(self._qemu_full_args)) + if self._iolog: + LOG.debug('Output: %r', self._iolog) raise def shutdown(self): -- cgit v1.2.3