From afd59989db90683fa127fec501d2633bcfbd6379 Mon Sep 17 00:00:00 2001 From: Peter Crosthwaite Date: Tue, 11 Jun 2013 11:00:40 +1000 Subject: intc/xilinx_intc: Dont lower IRQ when HIE cleared This is a little strange. It is lowering the parent IRQ pin on input when HIE is cleared. There is no such behaviour in the real hardware. ISR changes based on interrupt pin state are already guarded on HIE being set. So we can just delete this if in its entirety. Signed-off-by: Peter Crosthwaite Signed-off-by: Edgar E. Iglesias --- hw/intc/xilinx_intc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index ddedfa3796..297f53759c 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw/intc/xilinx_intc.c @@ -143,11 +143,6 @@ static void irq_handler(void *opaque, int irq, int level) { struct xlx_pic *p = opaque; - if (!(p->regs[R_MER] & 2)) { - qemu_irq_lower(p->parent_irq); - return; - } - /* edge triggered interrupt */ if (p->c_kind_of_intr & (1 << irq) && p->regs[R_MER] & 2) { p->regs[R_ISR] |= (level << irq); -- cgit v1.2.3