From 45bbe1fa897937e38d7db18ce214c28b01bab0ec Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Thu, 18 Apr 2013 11:53:32 -0400 Subject: virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event Because dev->actual is uint32_t, the expression 'dev->actual << VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when dev->actual >= 1048576. To reproduce: 1. Start a VM with a QMP socket and 5G of RAM 2. Connect to the QMP socket, negotiate capabilities and issue: { "execute":"balloon", "arguments": { "value": 1073741824 } } 3. Watch for BALLOON_CHANGE QMP events, the last one will incorretly be: { "timestamp": { "seconds": 1366228965, "microseconds": 245466 }, "event": "BALLOON_CHANGE", "data": { "actual": 5368709120 } } To fix it this commit casts it to ram_addr_t, which is ram_size's type. Signed-off-by: Luiz Capitulino Reviewed-by: Eric Blake (cherry picked from commit dcc6ceffc066745777960a1f0d32f3a555924f65) Signed-off-by: Michael Roth --- hw/virtio-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index c0a790264c..f841e81601 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -291,7 +291,7 @@ static void virtio_balloon_set_config(VirtIODevice *vdev, dev->actual = le32_to_cpu(config.actual); if (dev->actual != oldactual) { qemu_balloon_changed(ram_size - - (dev->actual << VIRTIO_BALLOON_PFN_SHIFT)); + ((ram_addr_t) dev->actual << VIRTIO_BALLOON_PFN_SHIFT)); } } -- cgit v1.2.3