diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-06-04 17:12:51 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2019-06-05 16:15:32 +0200 |
commit | edfb4389c26cbfd873707306024130bda6049780 (patch) | |
tree | bde176d81c95eebedd362721dc22d6dcc24d7fb7 /vl.c | |
parent | 9ea18ed25a36527167e9676f25d983df5e7f76e6 (diff) |
vl: Document why objects are delayed
Objects should not be "delayed" without a reason, as the previous
commit demonstrates. The remaining ones have reasons. State them.
and demand future ones come with such a statement.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190604151251.9903-3-armbru@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'vl.c')
-rw-r--r-- | vl.c | 10 |
1 files changed, 8 insertions, 2 deletions
@@ -2751,19 +2751,25 @@ static bool object_create_initial(const char *type, QemuOpts *opts) exit(0); } + /* + * Objects should not be made "delayed" without a reason. If you + * add one, state the reason in a comment! + */ + + /* Reason: rng-egd property "chardev" */ if (g_str_equal(type, "rng-egd")) { return false; } #if defined(CONFIG_VHOST_USER) && defined(CONFIG_LINUX) + /* Reason: cryptodev-vhost-user property "chardev" */ if (g_str_equal(type, "cryptodev-vhost-user")) { return false; } #endif /* - * return false for concrete netfilters since - * they depend on netdevs already existing + * Reason: filter-* property "netdev" etc. */ if (g_str_equal(type, "filter-buffer") || g_str_equal(type, "filter-dump") || |