diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /ui | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'ui')
| -rw-r--r-- | ui/cocoa.m | 1 | ||||
| -rw-r--r-- | ui/input-linux.c | 1 | ||||
| -rw-r--r-- | ui/spice-core.c | 1 | ||||
| -rw-r--r-- | ui/spice-display.c | 1 | ||||
| -rw-r--r-- | ui/vnc-auth-sasl.h | 1 | ||||
| -rw-r--r-- | ui/vnc.c | 1 |
6 files changed, 5 insertions, 1 deletions
diff --git a/ui/cocoa.m b/ui/cocoa.m index c2984028c5..c5a0d33c29 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -36,6 +36,7 @@ #include "qapi/qapi-commands-misc.h" #include "sysemu/blockdev.h" #include "qemu-version.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include <Carbon/Carbon.h> #include "qom/cpu.h" diff --git a/ui/input-linux.c b/ui/input-linux.c index c8d22f99d9..e3fa799c34 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -7,6 +7,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/config-file.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/sockets.h" #include "sysemu/sysemu.h" diff --git a/ui/spice-core.c b/ui/spice-core.c index 16478ecd45..a395d7ccd4 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -22,6 +22,7 @@ #include "ui/qemu-spice.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/thread.h" #include "qemu/timer.h" diff --git a/ui/spice-display.c b/ui/spice-display.c index 104df23025..0c65ae2fe3 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -18,6 +18,7 @@ #include "qemu/osdep.h" #include "ui/qemu-spice.h" #include "qemu/timer.h" +#include "qemu/main-loop.h" #include "qemu/option.h" #include "qemu/queue.h" #include "ui/console.h" diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h index fb55fe04ca..1bfb86c6f5 100644 --- a/ui/vnc-auth-sasl.h +++ b/ui/vnc-auth-sasl.h @@ -30,7 +30,6 @@ typedef struct VncStateSASL VncStateSASL; typedef struct VncDisplaySASL VncDisplaySASL; -#include "qemu/main-loop.h" #include "authz/base.h" struct VncStateSASL { @@ -31,6 +31,7 @@ #include "hw/qdev-core.h" #include "sysemu/sysemu.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/option.h" #include "qemu/sockets.h" |