aboutsummaryrefslogtreecommitdiff
path: root/tests/qemu-iotests/172
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2018-11-16 15:50:02 -0600
committerEric Blake <eblake@redhat.com>2018-11-19 11:16:46 -0600
commit8cedcffdc195bc39aeb1373826ba0a45629741e0 (patch)
tree46509d211d6dcf12f6d2923e9a37a1667177f762 /tests/qemu-iotests/172
parentbb39c47d70e84acf5066f79eba27ae5945b837be (diff)
iotests: Drop use of bash keyword 'function'
Bash allows functions to be declared with or without the leading keyword 'function'; but including the keyword does not comply with POSIX syntax, and is confusing to ksh users where the use of the keyword changes the scoping rules for functions. Stick to the POSIX form through iotests. Done mechanically with: sed -i 's/^function //' $(git ls-files tests/qemu-iotests) Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20181116215002.2124581-1-eblake@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/172')
-rwxr-xr-xtests/qemu-iotests/1726
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/qemu-iotests/172 b/tests/qemu-iotests/172
index c5ee33ee81..1e60a7e3d6 100755
--- a/tests/qemu-iotests/172
+++ b/tests/qemu-iotests/172
@@ -46,7 +46,7 @@ if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
_notrun "Requires a PC machine"
fi
-function do_run_qemu()
+do_run_qemu()
{
(
if ! test -t 0; then
@@ -59,7 +59,7 @@ function do_run_qemu()
echo
}
-function check_floppy_qtree()
+check_floppy_qtree()
{
echo
echo Testing: "$@" | _filter_testdir
@@ -75,7 +75,7 @@ function check_floppy_qtree()
_filter_win32 | _filter_qemu
}
-function check_cache_mode()
+check_cache_mode()
{
echo "info block none0" |
QEMU_OPTIONS="" do_run_qemu -drive if=none,file="$TEST_IMG" "$@" |