aboutsummaryrefslogtreecommitdiff
path: root/target
diff options
context:
space:
mode:
authorEric Farman <farman@linux.vnet.ibm.com>2017-01-20 17:25:26 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2017-01-27 18:07:31 +0100
commit482652502e98b1d570de0585f01dd55e35fdebfb (patch)
tree8dc5e287457d352a7a38ce5948690c45c8423f16 /target
parent2e144aa7793f4d2a2e8e0446f1e2c1e0eee79a93 (diff)
block: Fix target variable of BLKSECTGET ioctl
Commit 6f6071745bd0 ("raw-posix: Fetch max sectors for host block device") introduced a routine to call the kernel BLKSECTGET ioctl, which stores the result back to user space. However, the size of the data returned depends on the routine handling the ioctl. The (compat_)blkdev_ioctl returns a short, while sg_ioctl returns an int. Thus, on big-endian systems, we can find ourselves accidentally shifting the result to a much larger value. (On s390x, a short is 16 bits while an int is 32 bits.) Also, the two ioctl handlers return values in different scales (block returns sectors, while sg returns bytes), so some tweaking of the outputs is required such that hdev_get_max_transfer_length returns a value in a consistent set of units. Signed-off-by: Eric Farman <farman@linux.vnet.ibm.com> Message-Id: <20170120162527.66075-3-farman@linux.vnet.ibm.com> Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'target')
0 files changed, 0 insertions, 0 deletions