diff options
| author | Benoît Canet <benoit.canet@irqsave.net> | 2014-04-22 17:05:27 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-04-25 18:05:05 +0200 |
| commit | 1ba4b6a553ad9ff4645af7fab8adfc6e810fcc69 (patch) | |
| tree | 32c70dc0d83f4d06f4a2aae861557e73fd04ef77 /qemu-options.hx | |
| parent | 411f491e0af173cf8f39347574941bd26fbae381 (diff) | |
block: Prevent coroutine stack overflow when recursing in bdrv_open_backing_file.
In 1.7.1 qcow2_create2 reopen the file for flushing without the BDRV_O_NO_BACKING
flags.
As a consequence the code would recursively open the whole backing chain.
These three stack arrays would pile up through the recursion and lead to a coroutine
stack overflow.
Convert these array to malloced buffers in order to streamline the coroutine
footprint.
Symptoms where freezes or segfaults on production machines while taking QMP externals
snapshots. The overflow disturbed coroutine switching.
[Resolved conflicts on qemu.git/master since the patch was against v1.7.1
--Stefan]
Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'qemu-options.hx')
0 files changed, 0 insertions, 0 deletions