diff options
| author | Eric Blake <eblake@redhat.com> | 2016-04-07 19:09:37 -0600 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2016-04-15 17:56:56 +0200 |
| commit | 200650d49f558d8394625ef7ee452a093efdb921 (patch) | |
| tree | d534ed7efe5cad2237678e5976844777ae70b5c1 /qemu-nbd.c | |
| parent | e71fc0bae777e36e6c20271317bd2925628e074f (diff) | |
nbd: Don't fail handshake on NBD_OPT_LIST descriptions
The NBD Protocol states that NBD_REP_SERVER may set
'length > sizeof(namelen) + namelen'; in which case the rest
of the packet is a UTF-8 description of the export. While we
don't know of any NBD servers that send this description yet,
we had better consume the data so we don't choke when we start
to talk to such a server.
Also, a (buggy/malicious) server that replies with length <
sizeof(namelen) would cause us to block waiting for bytes that
the server is not sending, and one that replies with super-huge
lengths could cause us to temporarily allocate up to 4G memory.
Sanity check things before blindly reading incorrectly.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 1460077777-31004-1-git-send-email-eblake@redhat.com
Reviewed-by: Alex Bligh <alex@alex.org.uk>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qemu-nbd.c')
0 files changed, 0 insertions, 0 deletions