diff options
| author | Eric Blake <eblake@redhat.com> | 2016-01-29 06:48:59 -0700 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-02-08 17:29:57 +0100 |
| commit | 08f9541dec51700abef0c37994213164ca4e4fc9 (patch) | |
| tree | 2fbddce86ad35307b616aca8e795965e862b779f /qapi/string-output-visitor.c | |
| parent | bdd8e6b5d8a9def83d491a3f41c10424fc366258 (diff) | |
qapi: Drop unused error argument for list and implicit struct
No backend was setting an error when ending the visit of a list or
implicit struct, or when moving to the next list node. Make the
callers a bit easier to follow by making this a part of the contract,
and removing the errp argument - callers can then unconditionally end
an object as part of cleanup without having to think about whether a
second error is dominated by a first, because there is no second
error.
A later patch will then tackle the larger task of splitting
visit_end_struct(), which can indeed set an error.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-24-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qapi/string-output-visitor.c')
| -rw-r--r-- | qapi/string-output-visitor.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c index 3ce6a3bf67..b980bd3265 100644 --- a/qapi/string-output-visitor.c +++ b/qapi/string-output-visitor.c @@ -1,7 +1,7 @@ /* * String printing Visitor * - * Copyright Red Hat, Inc. 2012 + * Copyright Red Hat, Inc. 2012-2016 * * Author: Paolo Bonzini <pbonzini@redhat.com> * @@ -276,8 +276,7 @@ start_list(Visitor *v, const char *name, Error **errp) sov->head = true; } -static GenericList * -next_list(Visitor *v, GenericList **list, Error **errp) +static GenericList *next_list(Visitor *v, GenericList **list) { StringOutputVisitor *sov = to_sov(v); GenericList *ret = NULL; @@ -303,8 +302,7 @@ next_list(Visitor *v, GenericList **list, Error **errp) return ret; } -static void -end_list(Visitor *v, Error **errp) +static void end_list(Visitor *v) { StringOutputVisitor *sov = to_sov(v); |