diff options
| author | Peter Xu <peterx@redhat.com> | 2019-06-03 14:50:46 +0800 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2019-07-15 15:39:02 +0200 |
| commit | 267691b65cf7167881609dde1e50a4aafd86af08 (patch) | |
| tree | d1073f21fdecb2edab3913d2d75f78ae5fa9879c /migration | |
| parent | 422314e751ba071ca92152a544c0656882e5acde (diff) | |
migration: No need to take rcu during sync_dirty_bitmap
cpu_physical_memory_sync_dirty_bitmap() has one RAMBlock* as
parameter, which means that it must be with RCU read lock held
already. Taking it again inside seems redundant. Removing it.
Instead comment on the functions about the RCU read lock.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20190603065056.25211-2-peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/ram.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/migration/ram.c b/migration/ram.c index 89eec7ee9d..48969db84b 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1674,6 +1674,7 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs, return ret; } +/* Called with RCU critical section */ static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb, ram_addr_t length) { |