diff options
author | Zenghui Yu <yuzenghui@huawei.com> | 2021-03-12 19:21:43 +0800 |
---|---|---|
committer | Michael Roth <michael.roth@amd.com> | 2021-10-13 11:13:38 -0500 |
commit | 1513997aa2aac392d8a2e020feddd26f0f1fc4d3 (patch) | |
tree | e4df2fb3f0836fd0dc7a40534765765a6d6d59b9 /linux-user | |
parent | 609d7596524ab204ccd71ef42c9eee4c7c338ea4 (diff) |
multi-process: Initialize variables declared with g_auto*
Quote docs/devel/style.rst (section "Automatic memory deallocation"):
* Variables declared with g_auto* MUST always be initialized,
otherwise the cleanup function will use uninitialized stack memory
Initialize @name properly to get rid of the compilation error (using
gcc-7.3.0 on CentOS):
../hw/remote/proxy.c: In function 'pci_proxy_dev_realize':
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: 'name' may be used uninitialized in this function [-Werror=maybe-uninitialized]
g_free (*pp);
^~~~~~~~~~~~
../hw/remote/proxy.c:350:30: note: 'name' was declared here
g_autofree char *name;
^~~~
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
Message-id: 20210312112143.1369-1-yuzenghui@huawei.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit d90226808b5b1b30b07968e94d8f74bf8804fc89)
Signed-off-by: Michael Roth <michael.roth@amd.com>
Diffstat (limited to 'linux-user')
0 files changed, 0 insertions, 0 deletions