aboutsummaryrefslogtreecommitdiff
path: root/linux-user/ppc
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2024-11-19 13:02:06 +0000
committerPeter Maydell <peter.maydell@linaro.org>2024-11-19 13:02:06 +0000
commit3d7680fb18c7b17701730589d241a32e85f763a3 (patch)
tree8770a170e5b072e8dbf4d5c83adc2bc6cac7605a /linux-user/ppc
parent0340cb6e319341933443c1b1aee4c7ae816e8f7f (diff)
bitops.h: Define bit operations on 'uint32_t' arrays
Currently bitops.h defines a set of operations that work on arbitrary-length bit arrays. However (largely because they originally came from the Linux kernel) the bit array storage is an array of 'unsigned long'. This is OK for the kernel and even for parts of QEMU where we don't really care about the underlying storage format, but it is not good for devices, where we often want to expose the storage to the guest and so need a type that is not variably-sized between host OSes. We already have a workaround for this in the GICv3 model: arm_gicv3_common.h defines equivalents of the bit operations that work on uint32_t. It turns out that we should also be using something similar in hw/intc/loongarch_extioi.c, which currently casts a pointer to a uint32_t array to 'unsigned long *' in extio_setirq(), which is both undefined behaviour and not correct on a big-endian host. Define equivalents of the set_bit() function family which work with a uint32_t array. (Cc stable because we're about to provide a bugfix to loongarch_extioi which will depend on this commit.) Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20241108135514.4006953-2-peter.maydell@linaro.org
Diffstat (limited to 'linux-user/ppc')
0 files changed, 0 insertions, 0 deletions