diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-02-12 16:46:36 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2015-02-26 14:47:32 +0100 |
| commit | 39101f2511f6adf1ae4380f8d729dba1213b9d7a (patch) | |
| tree | 8c67d373be53ff4ad9d2a7e54112d4f0beb279be /include | |
| parent | cccb7967bdf19f9d31e65d2d07d4d311e07545c4 (diff) | |
QemuOpts: Convert qemu_opt_set_number() to Error, fix its use
Return the Error object instead of reporting it with
qerror_report_err().
Change callers that assume the function can't fail to pass
&error_abort, so that should the assumption ever break, it'll break
noisily.
Turns out all callers outside its unit test assume that. We could
drop the Error ** argument, but that would make the interface less
regular, so don't.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/qemu/option.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/qemu/option.h b/include/qemu/option.h index 320687494a..7422cc2aaa 100644 --- a/include/qemu/option.h +++ b/include/qemu/option.h @@ -99,7 +99,8 @@ void qemu_opt_set_err(QemuOpts *opts, const char *name, const char *value, Error **errp); void qemu_opt_set_bool(QemuOpts *opts, const char *name, bool val, Error **errp); -int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val); +void qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val, + Error **errp); typedef int (*qemu_opt_loopfunc)(const char *name, const char *value, void *opaque); int qemu_opt_foreach(QemuOpts *opts, qemu_opt_loopfunc func, void *opaque, int abort_on_failure); |