diff options
| author | Hanna Reitz <hreitz@redhat.com> | 2022-06-20 18:26:53 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-02-01 16:52:32 +0100 |
| commit | 3716470b24f0f63090d59bcf28ad8fe6fb7835bd (patch) | |
| tree | b697430a0cb2706f27dd90b1a3ca2314d069803c /include/block/qapi.h | |
| parent | fcb9e05144db51966e1476790129dbff92a0bea4 (diff) | |
block: Improve empty format-specific info dump
When a block driver supports obtaining format-specific information, but
that object only contains optional fields, it is possible that none of
them are present, so that dump_qobject() (called by
bdrv_image_info_specific_dump()) will not print anything.
The callers of bdrv_image_info_specific_dump() put a header above this
information ("Format specific information:\n"), which will look strange
when there is nothing below. Modify bdrv_image_info_specific_dump() to
print this header instead of its callers, and only if there is indeed
something to be printed.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220620162704.80987-2-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/block/qapi.h')
| -rw-r--r-- | include/block/qapi.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/block/qapi.h b/include/block/qapi.h index 865fb974d4..902fec81d5 100644 --- a/include/block/qapi.h +++ b/include/block/qapi.h @@ -40,6 +40,7 @@ void bdrv_query_image_info(BlockDriverState *bs, Error **errp); void bdrv_snapshot_dump(QEMUSnapshotInfo *sn); -void bdrv_image_info_specific_dump(ImageInfoSpecific *info_spec); +void bdrv_image_info_specific_dump(ImageInfoSpecific *info_spec, + const char *prefix); void bdrv_image_info_dump(ImageInfo *info); #endif |