diff options
| author | Avihai Horon <avihaih@nvidia.com> | 2024-03-04 12:53:39 +0200 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-03-11 14:41:40 -0400 |
| commit | ff64e0ba817d79968bffa88d205397abf05cc6e8 (patch) | |
| tree | c45d9cc30a4b564170f365fc643db848b0b9d08b /hw | |
| parent | 3f6ed59ec400a58646e766a323f7f8047f044b98 (diff) | |
vfio/migration: Add a note about migration rate limiting
VFIO migration buffer size is currently limited to 1MB. Therefore, there
is no need to check if migration rate exceeded, as in the worst case it
will exceed by only 1MB.
However, if the buffer size is later changed to a bigger value,
vfio_save_iterate() should enforce migration rate (similar to migration
RAM code).
Add a note about this in vfio_save_iterate() to serve as a reminder.
Suggested-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240304105339.20713-4-avihaih@nvidia.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/vfio/migration.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index 0af783a589..f82dcabc49 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -505,6 +505,12 @@ static bool vfio_is_active_iterate(void *opaque) return vfio_device_state_is_precopy(vbasedev); } +/* + * Note about migration rate limiting: VFIO migration buffer size is currently + * limited to 1MB, so there is no need to check if migration rate exceeded (as + * in the worst case it will exceed by 1MB). However, if the buffer size is + * later changed to a bigger value, migration rate should be enforced here. + */ static int vfio_save_iterate(QEMUFile *f, void *opaque) { VFIODevice *vbasedev = opaque; |