diff options
| author | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2010-05-14 22:52:30 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-05-21 11:49:18 +0200 |
| commit | de6c8042ec55da18702fa51f09072fcaa315edc3 (patch) | |
| tree | a968fe7b04f590a3ad082f323b52f00b3d83e475 /hw | |
| parent | c53a7285b4377e91f30b7742c7e12c16d6bf86f0 (diff) | |
virtio-blk: Avoid zeroing every request structure
The VirtIOBlockRequest structure is about 40 KB in size. This patch
avoids zeroing every request by only initializing fields that are read.
The other fields are either written to or may not be used at all.
Oprofile shows about 10% of CPU samples in memset called by
virtio_blk_alloc_request(). The workload is
dd if=/dev/vda of=/dev/null iflag=direct bs=8k running concurrently 4
times. This patch makes memset disappear to the bottom of the profile.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/virtio-blk.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index b05d15ecdd..d270225020 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -105,8 +105,10 @@ static void virtio_blk_flush_complete(void *opaque, int ret) static VirtIOBlockReq *virtio_blk_alloc_request(VirtIOBlock *s) { - VirtIOBlockReq *req = qemu_mallocz(sizeof(*req)); + VirtIOBlockReq *req = qemu_malloc(sizeof(*req)); req->dev = s; + req->qiov.size = 0; + req->next = NULL; return req; } |