diff options
| author | John Snow <jsnow@redhat.com> | 2019-03-11 21:51:46 +0300 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2019-03-12 14:57:38 -0400 |
| commit | d19c6b36ffe09cec7ce7ac6a3e979bfe923ebba9 (patch) | |
| tree | 3dcdf00d405fb293b204ab01dac792d65a9beca6 /block/qcow2.c | |
| parent | bf5f0cf5d819cce45dd578a19386d8b60022654f (diff) | |
block/qcow2-bitmap: Allow resizes with persistent bitmaps
Since we now load all bitmaps into memory anyway, we can just truncate
them in-memory and then flush them back to disk. Just in case, we will
still check and enforce that this shortcut is valid -- i.e. that any
bitmap described on-disk is indeed in-memory and can be modified.
If there are any inconsistent bitmaps, we refuse to allow the truncate
as we do not actually load these bitmaps into memory, and it isn't safe
or reasonable to attempt to truncate corrupted data.
Signed-off-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20190311185147.52309-4-vsementsov@virtuozzo.com
[vsementsov: drop bitmap flushing, fix block comments style]
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'block/qcow2.c')
| -rw-r--r-- | block/qcow2.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/qcow2.c b/block/qcow2.c index c4dd876fb4..d48e2e56f7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3646,9 +3646,7 @@ static int coroutine_fn qcow2_co_truncate(BlockDriverState *bs, int64_t offset, } /* cannot proceed if image has bitmaps */ - if (s->nb_bitmaps) { - /* TODO: resize bitmaps in the image */ - error_setg(errp, "Can't resize an image which has bitmaps"); + if (qcow2_truncate_bitmaps_check(bs, errp)) { ret = -ENOTSUP; goto fail; } |