diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2012-04-12 14:01:01 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2012-05-10 10:32:11 +0200 |
commit | 5f3777945d22248d805fb7c134e206c2d943b77b (patch) | |
tree | a150d2fad9a831d7497b152cc6f88691bc4081d6 /block.c | |
parent | e86fe18ac945a121a548347c48f2397d7a2e5be5 (diff) |
block: push bdrv_change_backing_file error checking up from drivers
This check applies to all drivers, but QED lacks it.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r-- | block.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -1460,6 +1460,11 @@ int bdrv_change_backing_file(BlockDriverState *bs, { BlockDriver *drv = bs->drv; + /* Backing file format doesn't make sense without a backing file */ + if (backing_fmt && !backing_file) { + return -EINVAL; + } + if (drv->bdrv_change_backing_file != NULL) { return drv->bdrv_change_backing_file(bs, backing_file, backing_fmt); } else { |