aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2012-03-12 10:30:02 +0100
committerKevin Wolf <kwolf@redhat.com>2012-04-05 14:54:39 +0200
commitfa6b8733c93107d7fcd7018d1822e93ba9edaa94 (patch)
tree997d298f560d4bac704b1b69bfadc8db54f4aa8d
parentbfe24e1a26d33d57df3c75e7f44273f0b0ca5943 (diff)
tracetool: Forbid argument name 'next'
It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rwxr-xr-xscripts/tracetool4
1 files changed, 4 insertions, 0 deletions
diff --git a/scripts/tracetool b/scripts/tracetool
index 47389b62ea..7b1c142b67 100755
--- a/scripts/tracetool
+++ b/scripts/tracetool
@@ -81,6 +81,10 @@ get_args()
args=${1#*\(}
args=${args%%\)*}
echo "$args"
+
+ if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then
+ echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n "
+ fi
}
# Get the argument name list of a trace event