aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGerd Hoffmann <kraxel@redhat.com>2020-10-19 09:52:13 +0200
committerGerd Hoffmann <kraxel@redhat.com>2020-10-21 15:46:14 +0200
commit63be30e6d53e78bbe5e21cbf930014ef4844fb31 (patch)
treec21989c2142805f241c33b7a368009c98b44c96b
parent7477477ca7bbf42588575039edcac852fbdb1d75 (diff)
spice: move qemu_spice_init() to QemuSpiceOps.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-id: 20201019075224.14803-4-kraxel@redhat.com
-rw-r--r--include/ui/qemu-spice-module.h1
-rw-r--r--include/ui/qemu-spice.h5
-rw-r--r--softmmu/vl.c2
-rw-r--r--ui/spice-core.c3
-rw-r--r--ui/spice-module.c5
5 files changed, 9 insertions, 7 deletions
diff --git a/include/ui/qemu-spice-module.h b/include/ui/qemu-spice-module.h
index 7a9963dd58..b182bc4c21 100644
--- a/include/ui/qemu-spice-module.h
+++ b/include/ui/qemu-spice-module.h
@@ -19,6 +19,7 @@
#define QEMU_SPICE_MODULE_H
struct QemuSpiceOps {
+ void (*init)(void);
int (*migrate_info)(const char *h, int p, int t, const char *s);
};
diff --git a/include/ui/qemu-spice.h b/include/ui/qemu-spice.h
index 3157016c2b..e6df0a8715 100644
--- a/include/ui/qemu-spice.h
+++ b/include/ui/qemu-spice.h
@@ -26,7 +26,6 @@
#include <spice.h>
#include "qemu/config-file.h"
-void qemu_spice_init(void);
void qemu_spice_input_init(void);
void qemu_spice_display_init(void);
int qemu_spice_display_add_client(int csock, int skipauth, int tls);
@@ -74,10 +73,6 @@ static inline void qemu_spice_display_init(void)
abort();
}
-static inline void qemu_spice_init(void)
-{
-}
-
#endif /* CONFIG_SPICE */
static inline bool qemu_using_spice(Error **errp)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index cb476aa70b..65c34a6b8a 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -4151,7 +4151,7 @@ void qemu_init(int argc, char **argv, char **envp)
/* spice needs the timers to be initialized by this point */
/* spice must initialize before audio as it changes the default auiodev */
/* spice must initialize before chardevs (for spicevmc and spiceport) */
- qemu_spice_init();
+ qemu_spice.init();
qemu_opts_foreach(qemu_find_opts("chardev"),
chardev_init_func, NULL, &error_fatal);
diff --git a/ui/spice-core.c b/ui/spice-core.c
index b03d743cf9..6ef66eb387 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -633,7 +633,7 @@ static void vm_change_state_handler(void *opaque, int running,
}
}
-void qemu_spice_init(void)
+static void qemu_spice_init(void)
{
QemuOpts *opts = QTAILQ_FIRST(&qemu_spice_opts.head);
const char *password, *str, *x509_dir, *addr,
@@ -994,6 +994,7 @@ int qemu_spice_display_is_running(SimpleSpiceDisplay *ssd)
}
static struct QemuSpiceOps real_spice_ops = {
+ .init = qemu_spice_init,
.migrate_info = qemu_spice_migrate_info,
};
diff --git a/ui/spice-module.c b/ui/spice-module.c
index f1939545a6..a30fa452ea 100644
--- a/ui/spice-module.c
+++ b/ui/spice-module.c
@@ -22,6 +22,10 @@
int using_spice;
+static void qemu_spice_init_stub(void)
+{
+}
+
static int qemu_spice_migrate_info_stub(const char *h, int p, int t,
const char *s)
{
@@ -29,5 +33,6 @@ static int qemu_spice_migrate_info_stub(const char *h, int p, int t,
}
struct QemuSpiceOps qemu_spice = {
+ .init = qemu_spice_init_stub,
.migrate_info = qemu_spice_migrate_info_stub,
};