aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristina Wang <christina.wang@windriver.com>2021-07-23 15:55:12 +0800
committerJason Wang <jasowang@redhat.com>2021-08-02 12:19:18 +0800
commitcfe6d6841ff46b43ec38792422f690813f4ce3bf (patch)
tree39948d70550c5fcc4945a0a0a4e9e6da13731c96
parentd897056960fb379302cc9b656b899829f571eb6e (diff)
hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor
In the legacy RX descriptor mode, VLAN tag was saved to d->special by e1000e_build_rx_metadata() in e1000e_write_lgcy_rx_descr(), but it was then zeroed out again at the end of the call, which is wrong. Fixes: c89d416a2b0f ("e1000e: Don't zero out buffer address in rx descriptor") Reported-by: Markus Carlstedt <markus.carlstedt@windriver.com> Signed-off-by: Christina Wang <christina.wang@windriver.com> Signed-off-by: Bin Meng <bin.meng@windriver.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
-rw-r--r--hw/net/e1000e_core.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index b4bf4ca2f1..8ae6fb7e14 100644
--- a/hw/net/e1000e_core.c
+++ b/hw/net/e1000e_core.c
@@ -1285,7 +1285,6 @@ e1000e_write_lgcy_rx_descr(E1000ECore *core, uint8_t *desc,
&d->special);
d->errors = (uint8_t) (le32_to_cpu(status_flags) >> 24);
d->status = (uint8_t) le32_to_cpu(status_flags);
- d->special = 0;
}
static inline void