diff options
author | Alexey Kardashevskiy <aik@ozlabs.ru> | 2014-07-01 17:30:27 +1000 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2014-07-01 10:36:28 +0200 |
commit | f80ea9862fed7ca89a672785bdce0e2611f9ba97 (patch) | |
tree | 45a86142fb457318c12b712e4dcb3a19552577cb | |
parent | 424baff549a9c8a7b5e814ce2bcb857d25163468 (diff) |
configure: Fix -lm test, so that tools can be compiled on hosts that require -lm
The existing test whether "-lm" needs to be included or not is
insufficient as it reports false negative on Fedora20/ppc64.
This happens because sin(0.0) is a constant value which compiler
can safely throw away and therefore there is no need to add "-lm".
As the result, qemu-nbd/qemu-io/qemu-img tools cannot compile.
This adds a global variable and uses it in the test to prevent
from optimization.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
[Use Peter's improvement on the test to fool LTO, and remove the
now useless -lm addition in Makefile.target. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r-- | Makefile.target | 4 | ||||
-rwxr-xr-x | configure | 2 |
2 files changed, 1 insertions, 5 deletions
diff --git a/Makefile.target b/Makefile.target index 6089d290df..137d0b0517 100644 --- a/Makefile.target +++ b/Makefile.target @@ -163,10 +163,6 @@ dummy := $(call unnest-vars,.., \ all-obj-y += $(common-obj-y) all-obj-$(CONFIG_SOFTMMU) += $(block-obj-y) -ifndef CONFIG_HAIKU -LIBS+=-lm -endif - # build either PROG or PROGW $(QEMU_PROG_BUILD): $(all-obj-y) ../libqemuutil.a ../libqemustub.a $(call LINK,$^) @@ -3453,7 +3453,7 @@ fi # Do we need libm cat > $TMPC << EOF #include <math.h> -int main(void) { return isnan(sin(0.0)); } +int main(int argc, char **argv) { return isnan(sin((double)argc)); } EOF if compile_prog "" "" ; then : |