From 28613aefdeca15ff5a857adf9d5d2b3dd4fdf53f Mon Sep 17 00:00:00 2001 From: Slack Coder Date: Sat, 27 Apr 2024 13:08:56 -0500 Subject: Fix logging Avoid emitting successful messages about installation when an error occurs. --- efi-sync | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/efi-sync b/efi-sync index 585b59f..331ce06 100644 --- a/efi-sync +++ b/efi-sync @@ -56,11 +56,17 @@ efi_install () { KERNEL_VERSION="$(basename $(realpath "$KERNEL") | sed -E 's/vmlinuz-(.*)-(.*)/\2/')" - cp -H "$KERNEL" "${EFI_KERNEL}"|| log "Failed to copy '${KERNEL}' into your EFI at '${EFI_KERNEL}'." + if ! cp -H "$KERNEL" "${EFI_KERNEL}"; then + log "Failed to copy '${KERNEL}' into your EFI at '${EFI_KERNEL}'." + return 1 + fi log "Installed $(realpath "$KERNEL")." if [[ -f /etc/mkinitrd.conf ]]; then - mkinitrd -F -c -k "${KERNEL_VERSION}" >/dev/null 2>&1 || log "mkinitrd failed to build and install your initial ramdisk." + if ! mkinitrd -F -c -k "${KERNEL_VERSION}" >/dev/null 2>&1; then + log "mkinitrd failed to build and install your initial ramdisk." + return 1 + fi log "Installed the initial RAM disk for kernel version '${KERNEL_VERSION}'." fi } -- cgit v1.2.3