diff options
| author | Neil Alexander <neilalexander@users.noreply.github.com> | 2022-07-18 14:49:41 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-18 14:49:41 +0100 |
| commit | 99b696e775f13eb876f68195acdbffc2e05764b2 (patch) | |
| tree | d433ff0fc6514fe158bd9e18316c62b0e3e26a9b /internal/caching | |
| parent | a7e92f8cb99105c2a579f73fbc972b7fb0b35678 (diff) | |
Tweak cache counters (#2575)
* Tweak cache counters
This makes the number of counters relative to the
maximum cache size. Since the counters
effectively manage the size of the bloom filter,
larger caches need more counters and smaller
caches need less.
10 counters per 1KB data means that the default
cache size of 1GB should result in a bloom filter
and TinyLRU admission set of about 16MB
estimated.
* Remove line left by accident
Diffstat (limited to 'internal/caching')
| -rw-r--r-- | internal/caching/impl_ristretto.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/internal/caching/impl_ristretto.go b/internal/caching/impl_ristretto.go index 677218b5..01c97ad5 100644 --- a/internal/caching/impl_ristretto.go +++ b/internal/caching/impl_ristretto.go @@ -44,9 +44,9 @@ const ( func NewRistrettoCache(maxCost config.DataUnit, maxAge time.Duration, enablePrometheus bool) *Caches { cache, err := ristretto.NewCache(&ristretto.Config{ - NumCounters: 1e5, // 10x number of expected cache items, affects bloom filter size, gives us room for 10,000 currently - BufferItems: 64, // recommended by the ristretto godocs as a sane buffer size value - MaxCost: int64(maxCost), + NumCounters: int64((maxCost / 1024) * 10), // 10 counters per 1KB data, affects bloom filter size + BufferItems: 64, // recommended by the ristretto godocs as a sane buffer size value + MaxCost: int64(maxCost), // max cost is in bytes, as per the Dendrite config Metrics: true, KeyToHash: func(key interface{}) (uint64, uint64) { return z.KeyToHash(key) |