From fa15a9934ee1d331737c631e6ffc2ddfafaddb7f Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Thu, 20 Apr 2023 12:23:44 +0200
Subject: test: Remove unused sanitizer suppressions

* The GCC suppression was fixed in gcc-11, which is available on all LTS
  releases of Linux distros.
* The feerate suppression was likely fixed and does not trigger anymore.
  If it was to trigger again, the underlying bug should be fixed instead
  of suppressing it.
* The bench suppression does not trigger anymore.

Also, add comments to tsan suppressions on how to reproduce.
---
 test/sanitizer_suppressions/tsan  | 4 +++-
 test/sanitizer_suppressions/ubsan | 6 ------
 2 files changed, 3 insertions(+), 7 deletions(-)

(limited to 'test')

diff --git a/test/sanitizer_suppressions/tsan b/test/sanitizer_suppressions/tsan
index d331991273..5a790b72f2 100644
--- a/test/sanitizer_suppressions/tsan
+++ b/test/sanitizer_suppressions/tsan
@@ -13,6 +13,8 @@ race:zmq::*
 race:bitcoin-qt
 
 # deadlock (TODO fix)
+# To reproduce, see:
+# https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1514926359
 deadlock:Chainstate::ConnectTip
 
 # Intentional deadlock in tests
@@ -35,7 +37,7 @@ race:libzmq
 # https://github.com/bitcoin/bitcoin/issues/20618
 race:CZMQAbstractPublishNotifier::SendZmqMessage
 
-# https://github.com/bitcoin/bitcoin/pull/20218, https://github.com/bitcoin/bitcoin/pull/20745
+# https://github.com/bitcoin/bitcoin/pull/27498#issuecomment-1517410478
 race:epoll_ctl
 
 # https://github.com/bitcoin/bitcoin/issues/23366
diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan
index 2fa4e383e2..6b891c462e 100644
--- a/test/sanitizer_suppressions/ubsan
+++ b/test/sanitizer_suppressions/ubsan
@@ -5,16 +5,12 @@
 # names can be used.
 # See https://github.com/google/sanitizers/issues/1364
 
-# https://github.com/bitcoin/bitcoin/pull/21798#issuecomment-829180719
-signed-integer-overflow:policy/feerate.cpp
-
 # -fsanitize=integer suppressions
 # ===============================
 # Dependencies
 # ------------
 # Suppressions in dependencies that are developed outside this repository.
 unsigned-integer-overflow:*/include/c++/
-unsigned-integer-overflow:bench/bench.h
 # unsigned-integer-overflow in FuzzedDataProvider's ConsumeIntegralInRange
 unsigned-integer-overflow:FuzzedDataProvider.h
 unsigned-integer-overflow:leveldb/
@@ -31,8 +27,6 @@ implicit-signed-integer-truncation:leveldb/
 implicit-unsigned-integer-truncation:*/include/c++/
 implicit-unsigned-integer-truncation:leveldb/
 implicit-unsigned-integer-truncation:test/fuzz/crypto_diff_fuzz_chacha20.cpp
-# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9
-implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage
 shift-base:*/include/c++/
 shift-base:leveldb/
 shift-base:minisketch/
-- 
cgit v1.2.3