From ada8358ef54aaa04c9182afe115d8046c801bdde Mon Sep 17 00:00:00 2001 From: amadeuszpawlik Date: Fri, 13 May 2022 22:29:09 +0200 Subject: Sanitize port in `addpeeraddress()` - Ensures port sanitization in `addpeeraddress()` - Adds test to check for invalid port values --- test/functional/rpc_net.py | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'test') diff --git a/test/functional/rpc_net.py b/test/functional/rpc_net.py index 81a3cfee97..ad8ba06824 100755 --- a/test/functional/rpc_net.py +++ b/test/functional/rpc_net.py @@ -257,6 +257,10 @@ class NetTest(BitcoinTestFramework): assert_equal(node.addpeeraddress(address="", port=8333), {"success": False}) assert_equal(node.getnodeaddresses(count=0), []) + self.log.debug("Test that adding an address with invalid port fails") + assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress, address="1.2.3.4", port=-1) + assert_raises_rpc_error(-1, "JSON integer out of range", self.nodes[0].addpeeraddress,address="1.2.3.4", port=65536) + self.log.debug("Test that adding a valid address to the tried table succeeds") assert_equal(node.addpeeraddress(address="1.2.3.4", tried=True, port=8333), {"success": True}) with node.assert_debug_log(expected_msgs=["CheckAddrman: new 0, tried 1, total 1 started"]): -- cgit v1.2.3