From 7a6627ae87b637bf32c03122865402bd71adf0d1 Mon Sep 17 00:00:00 2001 From: Samer Afach Date: Sat, 14 Mar 2020 14:44:56 +0100 Subject: Fix mining to an invalid target + ensure that a new block has the correct hash internally in Python tests --- test/functional/feature_block.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/functional/feature_block.py b/test/functional/feature_block.py index 95905f477b..0bedd1d2d7 100755 --- a/test/functional/feature_block.py +++ b/test/functional/feature_block.py @@ -632,7 +632,7 @@ class FullBlockTest(BitcoinTestFramework): self.move_tip(44) b47 = self.next_block(47, solve=False) target = uint256_from_compact(b47.nBits) - while b47.sha256 < target: + while b47.sha256 <= target: b47.nNonce += 1 b47.rehash() self.send_blocks([b47], False, force_send=True, reject_reason='high-hash', reconnect=True) @@ -1345,6 +1345,8 @@ class FullBlockTest(BitcoinTestFramework): block.hashMerkleRoot = block.calc_merkle_root() if solve: block.solve() + else: + block.rehash() self.tip = block self.block_heights[block.sha256] = height assert number not in self.blocks -- cgit v1.2.3