From c98bd13e675fbf5641ed64d551b63aaf55a1a8e9 Mon Sep 17 00:00:00 2001 From: Adam Jonas Date: Tue, 29 Oct 2019 16:26:01 -0400 Subject: replace asserts in RPC code with CHECK_NONFATAL and add linter --- test/lint/lint-assertions.sh | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'test/lint') diff --git a/test/lint/lint-assertions.sh b/test/lint/lint-assertions.sh index 5bbcae79eb..a4c6f0a8d4 100755 --- a/test/lint/lint-assertions.sh +++ b/test/lint/lint-assertions.sh @@ -20,4 +20,15 @@ if [[ ${OUTPUT} != "" ]]; then EXIT_CODE=1 fi +# Macro CHECK_NONFATAL(condition) should be used instead of assert for RPC code, where it +# is undesirable to crash the whole program. See: src/util/check.h +# src/rpc/server.cpp is excluded from this check since it's mostly meta-code. +OUTPUT=$(git grep -nE 'assert *\(.*\);' -- "src/rpc/" "src/wallet/rpc*" ":(exclude)src/rpc/server.cpp") +if [[ ${OUTPUT} != "" ]]; then + echo "CHECK_NONFATAL(condition) should be used instead of assert for RPC code." + echo + echo "${OUTPUT}" + EXIT_CODE=1 +fi + exit ${EXIT_CODE} -- cgit v1.2.3