From 0cfc0cd32239d3c08d2121e028b297022450b320 Mon Sep 17 00:00:00 2001 From: Vasil Dimov Date: Sun, 18 Oct 2020 14:45:35 +0200 Subject: net: fix GetListenPort() to derive the proper port `GetListenPort()` uses a simple logic: "if `-port=P` is given, then we must be listening on `P`, otherwise we must be listening on `8333`". This is however not true if `-bind=` has been provided with `:port` part or if `-whitebind=` has been provided. Thus, extend `GetListenPort()` to return the port from `-bind=` or `-whitebind=`, if any. Fixes https://github.com/bitcoin/bitcoin/issues/20184 (cases 1. 2. 3. 5.) --- test/functional/test_runner.py | 1 + 1 file changed, 1 insertion(+) (limited to 'test/functional/test_runner.py') diff --git a/test/functional/test_runner.py b/test/functional/test_runner.py index d15edcedd2..33afbfef6f 100755 --- a/test/functional/test_runner.py +++ b/test/functional/test_runner.py @@ -276,6 +276,7 @@ BASE_SCRIPTS = [ 'feature_minchainwork.py', 'rpc_estimatefee.py', 'rpc_getblockstats.py', + 'feature_bind_port_externalip.py', 'wallet_create_tx.py --legacy-wallet', 'wallet_send.py --legacy-wallet', 'wallet_send.py --descriptors', -- cgit v1.2.3