From 9816dc96b77fd9780bb97891cd45a1b9798db8f5 Mon Sep 17 00:00:00 2001 From: Anthony Towns Date: Sat, 5 Mar 2022 04:44:58 +1000 Subject: net: note CNode members that are treated as const m_permissionFlags and m_prefer_evict are treated as const -- they're only set immediately after construction before any other thread has access to the object, and not changed again afterwards. As such they don't need to be marked atomic or guarded by a mutex; though it would probably be better to actually mark them as const... --- src/net.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/net.h b/src/net.h index d062b8a9ff..abdfef85f8 100644 --- a/src/net.h +++ b/src/net.h @@ -344,7 +344,7 @@ public: const std::unique_ptr m_deserializer; // Used only by SocketHandler thread const std::unique_ptr m_serializer; - NetPermissionFlags m_permissionFlags{NetPermissionFlags::None}; + NetPermissionFlags m_permissionFlags{NetPermissionFlags::None}; // treated as const outside of fuzz tester /** * Socket used for communication with the node. @@ -393,7 +393,7 @@ public: * from the wire. This cleaned string can safely be logged or displayed. */ std::string cleanSubVer GUARDED_BY(m_subver_mutex){}; - bool m_prefer_evict{false}; // This peer is preferred for eviction. + bool m_prefer_evict{false}; // This peer is preferred for eviction. (treated as const) bool HasPermission(NetPermissionFlags permission) const { return NetPermissions::HasFlag(m_permissionFlags, permission); } -- cgit v1.2.3