From 66ed2423434ab9712ebd1625abdd55d8a693d905 Mon Sep 17 00:00:00 2001 From: practicalswift Date: Tue, 17 Jul 2018 19:21:33 +0200 Subject: Remove redundant forward declaration --- src/qt/clientmodel.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'src') diff --git a/src/qt/clientmodel.cpp b/src/qt/clientmodel.cpp index a623771aa0..8a4a2955f6 100644 --- a/src/qt/clientmodel.cpp +++ b/src/qt/clientmodel.cpp @@ -28,8 +28,6 @@ #include #include -class CBlockIndex; - static int64_t nLastHeaderTipUpdateNotification = 0; static int64_t nLastBlockTipUpdateNotification = 0; -- cgit v1.2.3 From 99be644966c63e9917161f97574905551e44360f Mon Sep 17 00:00:00 2001 From: practicalswift Date: Tue, 17 Jul 2018 19:22:17 +0200 Subject: Remove redundant unused variables --- src/script/standard.cpp | 2 -- src/test/miner_tests.cpp | 2 +- src/test/transaction_tests.cpp | 1 - src/txmempool.cpp | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) (limited to 'src') diff --git a/src/script/standard.cpp b/src/script/standard.cpp index f0b2c62a91..d7b1724790 100644 --- a/src/script/standard.cpp +++ b/src/script/standard.cpp @@ -324,8 +324,6 @@ CScript GetScriptForMultisig(int nRequired, const std::vector& keys) CScript GetScriptForWitness(const CScript& redeemscript) { - CScript ret; - txnouttype typ; std::vector > vSolutions; if (Solver(redeemscript, typ, vSolutions)) { diff --git a/src/test/miner_tests.cpp b/src/test/miner_tests.cpp index 9a325f5f4c..10c7fd00e8 100644 --- a/src/test/miner_tests.cpp +++ b/src/test/miner_tests.cpp @@ -209,7 +209,7 @@ BOOST_AUTO_TEST_CASE(CreateNewBlock_validity) const CChainParams& chainparams = *chainParams; CScript scriptPubKey = CScript() << ParseHex("04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f") << OP_CHECKSIG; std::unique_ptr pblocktemplate; - CMutableTransaction tx,tx2; + CMutableTransaction tx; CScript script; uint256 hash; TestMemPoolEntryHelper entry; diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 45dc0e3571..aff270942e 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -547,7 +547,6 @@ BOOST_AUTO_TEST_CASE(test_witness) CTransactionRef output1, output2; CMutableTransaction input1, input2; - SignatureData sigdata; // Normal pay-to-compressed-pubkey. CreateCreditAndSpend(keystore, scriptPubkey1, output1, input1); diff --git a/src/txmempool.cpp b/src/txmempool.cpp index 8090172e3f..1db006ecd1 100644 --- a/src/txmempool.cpp +++ b/src/txmempool.cpp @@ -716,7 +716,6 @@ void CTxMemPool::check(const CCoinsViewCache *pcoins) const while (!waitingOnDependants.empty()) { const CTxMemPoolEntry* entry = waitingOnDependants.front(); waitingOnDependants.pop_front(); - CValidationState state; if (!mempoolDuplicate.HaveInputs(entry->GetTx())) { waitingOnDependants.push_back(entry); stepsSinceLastRemove++; -- cgit v1.2.3 From 3dee4cc5098c6e9bcc13df9d6277478c8273a6cd Mon Sep 17 00:00:00 2001 From: practicalswift Date: Tue, 17 Jul 2018 19:23:46 +0200 Subject: Remove redundant statement --- src/wallet/coinselection.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/wallet/coinselection.cpp b/src/wallet/coinselection.cpp index a403411e5b..78258cdec2 100644 --- a/src/wallet/coinselection.cpp +++ b/src/wallet/coinselection.cpp @@ -115,7 +115,7 @@ bool SelectCoinsBnB(std::vector& utxo_pool, const CAmount& target_va while (!curr_selection.empty() && !curr_selection.back()) { curr_selection.pop_back(); curr_available_value += utxo_pool.at(curr_selection.size()).effective_value; - }; + } if (curr_selection.empty()) { // We have walked back to the first utxo and no branch is untraversed. All solutions searched break; -- cgit v1.2.3