From e2ad343f69af4f924b22dccf94a52b6431ef6e3c Mon Sep 17 00:00:00 2001 From: Sebastian Falbesoner Date: Thu, 9 Nov 2023 14:02:21 +0100 Subject: wallet: remove unused `SignatureData` instances in spkm's `FillPSBT` methods These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. --- src/wallet/scriptpubkeyman.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src') diff --git a/src/wallet/scriptpubkeyman.cpp b/src/wallet/scriptpubkeyman.cpp index 6bbe6a1647..b7420d5fb7 100644 --- a/src/wallet/scriptpubkeyman.cpp +++ b/src/wallet/scriptpubkeyman.cpp @@ -652,8 +652,6 @@ TransactionError LegacyScriptPubKeyMan::FillPSBT(PartiallySignedTransaction& psb // There's no UTXO so we can just skip this now continue; } - SignatureData sigdata; - input.FillSignatureData(sigdata); SignPSBTInput(HidingSigningProvider(this, !sign, !bip32derivs), psbtx, i, &txdata, sighash_type, nullptr, finalize); bool signed_one = PSBTInputSigned(input); @@ -2520,8 +2518,6 @@ TransactionError DescriptorScriptPubKeyMan::FillPSBT(PartiallySignedTransaction& // There's no UTXO so we can just skip this now continue; } - SignatureData sigdata; - input.FillSignatureData(sigdata); std::unique_ptr keys = std::make_unique(); std::unique_ptr script_keys = GetSigningProvider(script, /*include_private=*/sign); -- cgit v1.2.3