From 033477dba65151b1863214606d5a49686ab6f559 Mon Sep 17 00:00:00 2001 From: Martin Zumsande Date: Tue, 23 Jan 2024 10:58:25 -0500 Subject: doc: fix checkblockindex comments These exceptions are not related to situations specific to tests, but are required in general: Without the first check CheckBlockindex could fail for blocks where we only know the header. Without the second, it could fail when blocks are received out of order. --- src/validation.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/validation.cpp b/src/validation.cpp index 8c583c586c..e47ce5edbd 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -4865,9 +4865,9 @@ void ChainstateManager::CheckBlockIndex() // Make sure nChainTx sum is correctly computed. unsigned int prev_chain_tx = pindex->pprev ? pindex->pprev->nChainTx : 0; assert((pindex->nChainTx == pindex->nTx + prev_chain_tx) - // For testing, allow transaction counts to be completely unset. + // Transaction may be completely unset - happens if only the header was accepted but the block hasn't been processed. || (pindex->nChainTx == 0 && pindex->nTx == 0) - // For testing, allow this nChainTx to be unset if previous is also unset. + // nChainTx may be unset, but nTx set (if a block has been accepted, but one of its predecessors hasn't been processed yet) || (pindex->nChainTx == 0 && prev_chain_tx == 0 && pindex->pprev) // Transaction counts prior to snapshot are unknown. || pindex->IsAssumedValid()); -- cgit v1.2.3