From 9a5b5ee81f15b1d89cb25ff3e137a672536cdc46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Barbosa?= Date: Tue, 29 May 2018 14:37:53 +0100 Subject: wallet: Replace %w by wallet name in -walletnotify script Co-authored-by: Russell Yanofsky --- src/wallet/wallet.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/wallet/wallet.cpp') diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 559b26aa84..fd8c68870d 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -835,6 +835,14 @@ bool CWallet::AddToWallet(const CWalletTx& wtxIn, bool fFlushOnClose) if (!strCmd.empty()) { boost::replace_all(strCmd, "%s", wtxIn.GetHash().GetHex()); +#ifndef WIN32 + // Substituting the wallet name isn't currently supported on windows + // because windows shell escaping has not been implemented yet: + // https://github.com/bitcoin/bitcoin/pull/13339#issuecomment-537384875 + // A few ways it could be implemented in the future are described in: + // https://github.com/bitcoin/bitcoin/pull/13339#issuecomment-461288094 + boost::replace_all(strCmd, "%w", ShellEscape(GetName())); +#endif std::thread t(runCommand, strCmd); t.detach(); // thread runs free } -- cgit v1.2.3