From 3d985d4f43b5344f998bcf6db22d02782e647a2a Mon Sep 17 00:00:00 2001 From: Andrew Chow Date: Wed, 16 Feb 2022 22:31:20 -0500 Subject: wallet: Don't generate keys when privkeys disabled when upgrading When private keys are disabled, we should not be trying to generate new keys during upgradewallet. --- src/wallet/scriptpubkeyman.cpp | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/wallet/scriptpubkeyman.cpp') diff --git a/src/wallet/scriptpubkeyman.cpp b/src/wallet/scriptpubkeyman.cpp index 7218ed11dc..53f7b773b4 100644 --- a/src/wallet/scriptpubkeyman.cpp +++ b/src/wallet/scriptpubkeyman.cpp @@ -469,6 +469,12 @@ bool LegacyScriptPubKeyMan::CanGetAddresses(bool internal) const bool LegacyScriptPubKeyMan::Upgrade(int prev_version, int new_version, bilingual_str& error) { LOCK(cs_KeyStore); + + if (m_storage.IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS)) { + // Nothing to do here if private keys are not enabled + return true; + } + bool hd_upgrade = false; bool split_upgrade = false; if (IsFeatureSupported(new_version, FEATURE_HD) && !IsHDEnabled()) { -- cgit v1.2.3