From 5d465e396249a0e2cc60b16984a2bdbe4c8993c3 Mon Sep 17 00:00:00 2001 From: Tomas van der Wansem Date: Thu, 21 Sep 2017 00:10:46 +0200 Subject: Ensure backupwallet fails when attempting to backup to source file Previous behaviour was to destroy the wallet (to zero-length) --- src/wallet/db.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/wallet/db.cpp') diff --git a/src/wallet/db.cpp b/src/wallet/db.cpp index d66ba48421..d49cd82340 100644 --- a/src/wallet/db.cpp +++ b/src/wallet/db.cpp @@ -672,6 +672,11 @@ bool CWalletDBWrapper::Backup(const std::string& strDest) pathDest /= strFile; try { + if (fs::equivalent(pathSrc, pathDest)) { + LogPrintf("cannot backup to wallet source file %s\n", pathDest.string()); + return false; + } + fs::copy_file(pathSrc, pathDest, fs::copy_option::overwrite_if_exists); LogPrintf("copied %s to %s\n", strFile, pathDest.string()); return true; -- cgit v1.2.3