From a0d495747320c79b27a83c216dcc526ac8df8f24 Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Wed, 4 Nov 2020 13:13:17 +0100 Subject: wallet: introduce fee_rate (sat/vB) param/option Create a fee_rate (sat/vB) RPC param and replace overloading the conf_target and estimate_mode params in the following 6 RPCs with it: - sendtoaddress - sendmany - send - fundrawtransaction - walletcreatefundedpsbt - bumpfee In RPC bumpfee, the previously existing fee_rate remains but the unit is changed from BTC/kvB to sat/vB. This is a breaking change, but it should not be an overly risky one, as the units change by a factor of 1e5 and any fees specified in BTC/kvB after this commit will either be too low and raise an error or be 1 sat/vB and can be RBFed. Update the test coverage for each RPC. Co-authored-by: Murch --- src/util/fees.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/util') diff --git a/src/util/fees.cpp b/src/util/fees.cpp index 6208a20a97..9a1cea1d4e 100644 --- a/src/util/fees.cpp +++ b/src/util/fees.cpp @@ -40,8 +40,6 @@ const std::vector>& FeeModeMap() {"unset", FeeEstimateMode::UNSET}, {"economical", FeeEstimateMode::ECONOMICAL}, {"conservative", FeeEstimateMode::CONSERVATIVE}, - {(CURRENCY_UNIT + "/kB"), FeeEstimateMode::BTC_KB}, - {(CURRENCY_ATOM + "/B"), FeeEstimateMode::SAT_B}, }; return FEE_MODES; } -- cgit v1.2.3