From fa61202cae6979c754b11842c5ed8d90f1cdcc45 Mon Sep 17 00:00:00 2001
From: MarcoFalke <falke.marco@gmail.com>
Date: Mon, 17 Dec 2018 13:19:07 -0500
Subject: test: Add comment to g_insecure_rand_ctx

---
 src/test/test_bitcoin.h | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'src/test')

diff --git a/src/test/test_bitcoin.h b/src/test/test_bitcoin.h
index 2d49faf8c9..31d90c0151 100644
--- a/src/test/test_bitcoin.h
+++ b/src/test/test_bitcoin.h
@@ -26,6 +26,13 @@ std::ostream& operator<<(typename std::enable_if<std::is_enum<T>::value, std::os
     return stream << static_cast<typename std::underlying_type<T>::type>(e);
 }
 
+/**
+ * This global and the helpers that use it are not thread-safe.
+ *
+ * If thread-safety is needed, the global could be made thread_local (given
+ * that thread_local is supported on all architectures we support) or a
+ * per-thread instance could be used in the multi-threaded test.
+ */
 extern FastRandomContext g_insecure_rand_ctx;
 
 static inline void SeedInsecureRand(bool deterministic = false)
-- 
cgit v1.2.3