From fadb39ca6237781346ca3da319e2bd9e48a5a604 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Sat, 17 Feb 2018 14:29:56 -0500 Subject: test: Plug memory leaks and stack-use-after-scope --- src/test/checkqueue_tests.cpp | 8 ++++---- src/test/test_bitcoin.cpp | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) (limited to 'src/test') diff --git a/src/test/checkqueue_tests.cpp b/src/test/checkqueue_tests.cpp index 42f9dd0600..8e0ec5243b 100644 --- a/src/test/checkqueue_tests.cpp +++ b/src/test/checkqueue_tests.cpp @@ -406,11 +406,11 @@ BOOST_AUTO_TEST_CASE(test_CheckQueueControl_Locks) boost::thread_group tg; std::mutex m; std::condition_variable cv; + bool has_lock{false}; + bool has_tried{false}; + bool done{false}; + bool done_ack{false}; { - bool has_lock {false}; - bool has_tried {false}; - bool done {false}; - bool done_ack {false}; std::unique_lock l(m); tg.create_thread([&]{ CCheckQueueControl control(queue.get()); diff --git a/src/test/test_bitcoin.cpp b/src/test/test_bitcoin.cpp index bdd44489f4..95c4825b84 100644 --- a/src/test/test_bitcoin.cpp +++ b/src/test/test_bitcoin.cpp @@ -28,6 +28,9 @@ void CConnmanTest::AddNode(CNode& node) void CConnmanTest::ClearNodes() { LOCK(g_connman->cs_vNodes); + for (CNode* node : g_connman->vNodes) { + delete node; + } g_connman->vNodes.clear(); } -- cgit v1.2.3