From facf629ce8ff1d1f6d254dde4e89b5018f8df60e Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Tue, 21 Nov 2023 17:06:22 +0100
Subject: refactor: Remove unused and fragile string interface from
 arith_uint256

---
 src/test/uint256_tests.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/test/uint256_tests.cpp')

diff --git a/src/test/uint256_tests.cpp b/src/test/uint256_tests.cpp
index 933988dd7a..8aa540e761 100644
--- a/src/test/uint256_tests.cpp
+++ b/src/test/uint256_tests.cpp
@@ -260,8 +260,8 @@ BOOST_AUTO_TEST_CASE( conversion )
     BOOST_CHECK(UintToArith256(OneL) == 1);
     BOOST_CHECK(ArithToUint256(0) == ZeroL);
     BOOST_CHECK(ArithToUint256(1) == OneL);
-    BOOST_CHECK(arith_uint256(R1L.GetHex()) == UintToArith256(R1L));
-    BOOST_CHECK(arith_uint256(R2L.GetHex()) == UintToArith256(R2L));
+    BOOST_CHECK(arith_uint256(UintToArith256(uint256S(R1L.GetHex()))) == UintToArith256(R1L));
+    BOOST_CHECK(arith_uint256(UintToArith256(uint256S(R2L.GetHex()))) == UintToArith256(R2L));
     BOOST_CHECK(R1L.GetHex() == UintToArith256(R1L).GetHex());
     BOOST_CHECK(R2L.GetHex() == UintToArith256(R2L).GetHex());
 }
-- 
cgit v1.2.3


From fa63f16018d9468e1751d2107b5102184ac2d5ae Mon Sep 17 00:00:00 2001
From: MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>
Date: Tue, 21 Nov 2023 17:04:21 +0100
Subject: test: Add uint256 string parse tests

---
 src/test/uint256_tests.cpp | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

(limited to 'src/test/uint256_tests.cpp')

diff --git a/src/test/uint256_tests.cpp b/src/test/uint256_tests.cpp
index 8aa540e761..b363b4c04d 100644
--- a/src/test/uint256_tests.cpp
+++ b/src/test/uint256_tests.cpp
@@ -279,6 +279,34 @@ BOOST_AUTO_TEST_CASE( operator_with_self )
     BOOST_CHECK(v == UintToArith256(uint256S("0")));
 }
 
+BOOST_AUTO_TEST_CASE(parse)
+{
+    {
+        std::string s_12{"0000000000000000000000000000000000000000000000000000000000000012"};
+        BOOST_CHECK_EQUAL(uint256S("12\0").GetHex(), s_12);
+        BOOST_CHECK_EQUAL(uint256S(std::string{"12\0", 3}).GetHex(), s_12);
+        BOOST_CHECK_EQUAL(uint256S("0x12").GetHex(), s_12);
+        BOOST_CHECK_EQUAL(uint256S(" 0x12").GetHex(), s_12);
+        BOOST_CHECK_EQUAL(uint256S(" 12").GetHex(), s_12);
+    }
+    {
+        std::string s_1{uint256::ONE.GetHex()};
+        BOOST_CHECK_EQUAL(uint256S("1\0").GetHex(), s_1);
+        BOOST_CHECK_EQUAL(uint256S(std::string{"1\0", 2}).GetHex(), s_1);
+        BOOST_CHECK_EQUAL(uint256S("0x1").GetHex(), s_1);
+        BOOST_CHECK_EQUAL(uint256S(" 0x1").GetHex(), s_1);
+        BOOST_CHECK_EQUAL(uint256S(" 1").GetHex(), s_1);
+    }
+    {
+        std::string s_0{uint256::ZERO.GetHex()};
+        BOOST_CHECK_EQUAL(uint256S("\0").GetHex(), s_0);
+        BOOST_CHECK_EQUAL(uint256S(std::string{"\0", 1}).GetHex(), s_0);
+        BOOST_CHECK_EQUAL(uint256S("0x").GetHex(), s_0);
+        BOOST_CHECK_EQUAL(uint256S(" 0x").GetHex(), s_0);
+        BOOST_CHECK_EQUAL(uint256S(" ").GetHex(), s_0);
+    }
+}
+
 BOOST_AUTO_TEST_CASE( check_ONE )
 {
     uint256 one = uint256S("0000000000000000000000000000000000000000000000000000000000000001");
-- 
cgit v1.2.3